Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed radom state in splitting and train #4907

Closed

Conversation

kohn1001
Copy link

@kohn1001 kohn1001 commented Dec 4, 2019

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing
Copy link
Contributor

@kohn1001 is this in a reviewable state? Looks like there are merge conflicts. Can you also add a description of the problem you encountered and are trying to solve?

@kohn1001
Copy link
Author

Yeah - I see that you add the functionality I needed - fix the random seed for every train/test split

@kohn1001
Copy link
Author

This PR has been merged and doing what I need :)
#4842

@erohmensing
Copy link
Contributor

Awesome, I will close this then 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants